search

erthink / libmdbx

One of the fastest embeddable key-value ACID database without WAL. libmdbx surpasses the legendary LMDB in terms of reliability, features and performance.
https://erthink.github.io/libmdbx/
Other
1.16k stars 111 forks source link

Consider to delete MDBX_BUILD_TIMESTAMP #201

Closed AskAlexSharov closed 3 years ago

AskAlexSharov commented 3 years ago

There is no logic based on this constant.

But it breaks reproducibility of app builds: shasum -a256 mybinary is different from build to build only because of MDBX_BUILD_TIMESTAMP. Reproducibility checksum useful for security reasons - to check that no malware code was embedded into app sources during "release binary artifacts" process.

erthink commented 3 years ago

It was assumed that the ability to predefine MDBX_BUILD_TIMESTAMP for builds reproducibility would be added. Looks like it's time to do it.

AskAlexSharov commented 3 years ago

It works:

MDBX_BUILD_TIMESTAMP=unknown make config.h
make mdbx-static.o