search

ertyseidohl / Fhtagn

Find The Acolytes of The Dark One Before They Consume Us All :D
3 stars 4 forks source link

Text question type #25

Closed ceaess closed 9 years ago

ceaess commented 9 years ago

Add a dynamic answer question -- temporarily display it directly to the page for testing pages.

ceaess commented 9 years ago

@ertyseidohl thoughts?

ertyseidohl commented 9 years ago

I get the feeling that there's a better way to handle this than a bunch of if-else statements but I'm not sure what it is. I'll ask at work today.

ertyseidohl commented 9 years ago

It just feels weird to me to be passing a lot of different types into the question controller and sorting them out inside, instead of passing them to a controller that just does what we want.

ceaess commented 9 years ago

@ertyseidohl did some refactoring based on your suggestions. Further thoughts?

ertyseidohl commented 9 years ago

Looks good and clean! Some very minor style nitpicks that don't actually affect the code. :+1: