erudisiya / moodle-local_delegate

1 stars 0 forks source link

style.css named incorrectly (should be styles.css) and not specific enough. #3

Open danmarsden opened 9 months ago

danmarsden commented 9 months ago

in your styles.css you define a number of generic styles that could clash with core moodle code or other locations where simliar names are used.

Moodle helpfully adds a number of classes to the body tag based on the path that you can use such as: eg if you are have a file in mod/assign you would see the following class added to the body tag path-mod-assign so if you have an item with the class "filething" on the page you would target it like:

.path-mod-assign .filething {
   color: red;
}

Please make sure your css classes in styles.css are specific enough so they cannot clash with other core code.

erudisiya commented 8 months ago

Thanks for this suggestion. I have fixed the issue.

danmarsden commented 7 months ago

the style.css file is still there and should be deleted.

erudisiya commented 7 months ago

3 problem solved.