search

erunion / showtimes

[deprecated] a movie showtimes API
MIT License
52 stars 14 forks source link

some turkish encoding issues fixed. #25

Closed berkaytheunicorn closed 9 years ago

berkaytheunicorn commented 9 years ago

I don't know if this is the best approach but fixes the problem. I tested with en, de, tr so far so good. The last fixed I sent only worked with if the lang is "en" and also page contains turkish strings but if you change the lang to "tr", turkish chars. won't be encoded correctly.

erunion commented 9 years ago

Is it possible to write a unit test for this?

berkaytheunicorn commented 9 years ago

actually Im not good with writing tests and even if I do It will be hard to match if there is a abnormal characters.

erunion commented 9 years ago

k. i'll take your word that this works. :p

erunion commented 9 years ago

Tagged to 1.7.0