search

erunion / showtimes

[deprecated] a movie showtimes API
MIT License
52 stars 14 forks source link

Adding getMovies method to get a list of movies. #28

Closed chrux closed 8 years ago

erunion commented 8 years ago

Nice!

erunion commented 8 years ago

Really awesome work on this. After merging it all in and looking at how hairy the library had become, I decided tonight to, first learn how to and then, rebuild it all in ES6. I've shifted your code around a bit and merged it in with some new components I wrote that'll make it really easy to add new features into.

Anyway, long story short, I've published 2.0.0 with your changes, and my ES6 rewrite. It isn't backwards compatible, unfortunately, but is trivial to update to. I've written some docs on upgrading here: https://github.com/erunion/showtimes#upgrading-to-v2

:pizza: :beers:

chrux commented 8 years ago

:+1: cool, I have some ideas to a couple of feature I hope to post them to you soon :)