search

erunion / showtimes

[deprecated] a movie showtimes API
MIT License
52 stars 14 forks source link

Ternary operator to not trim undefined address or phone number #8

Closed jstart closed 9 years ago

jstart commented 9 years ago

Was seeing error when fetching zipcode: 75201

TypeError: Cannot call method 'trim' of undefined

erunion commented 9 years ago

Thanks for the fix. Merged it into master, but there are some failing tests. I'll see if I can get those fixed this evening, and then package up a 0.4.0 release.

jstart commented 9 years ago

Noticed the failure, it seems that continuing with some undefined fields causes problems further down. I'll see if there is anything I can clean up as well.

erunion commented 9 years ago

Made a ticket for the failing unit tests. #9