X3n0m0rph59
commented
3 years ago Hi! Thanks for your feature request!
I thought about implementing this too, since user supplied scripts/per-user profiles would be really nice to have! I refrained from implementing it because of the security implications this has. It would require a huge change in the security model of Eruption. The Eruption daemon needs to run with elevated privileges to access the hardware. If it would be possible for a regular user to arbitrarily load and run Lua code, this could be easily exploited in multiple ways to gain root privileges. It would increase the attack surface of Eruption by a huge margin.
One possible solution to this problem is implemented in the eruption-gui branch that I am working on. Basically the Eruption GUI uses PolicyKit to authenticate the user as an administrator. When the user changes a configuration value via the GUI, the Eruption GUI process (running as a regular user) calls into Eruption (running as root) via a D-Bus based API and requests a change of that configuration value (or even of Lua code). The Eruption daemon only executes this request if PolicyKit confirms that the user running the GUI process is authenticated with the required permissions. This basically resembles the way other shared hardware resources are managed on Linux, like e.g. printer devices.
Implementing it this way has the following disadvantages:
- It will not deliver per-user separation of profiles and scripts, we only have a single namespace
- It reduces the attack surface of the Eruption daemon but requires authentication of the user
In the current security model, we basically have three levels of permissions: Monitor, Settings and Manage.
Excerpt of the PolicyKit configuration:
<!-- Monitor the Eruption daemons state -->
<action id="org.eruption.monitor">
<description>Monitor Eruption</description>
<message>Authentication is required to monitor Eruption</message>
<defaults>
<allow_any>yes</allow_any>
<allow_inactive>yes</allow_inactive>
<allow_active>yes</allow_active>
</defaults>
</action>
<!-- Change non-privileged settings like e.g.: LED Brightness -->
<action id="org.eruption.settings">
<description>Change settings of Eruption</description>
<message>Authentication is required to change the settings of Eruption</message>
<defaults>
<allow_any>yes</allow_any>
<allow_inactive>yes</allow_inactive>
<allow_active>yes</allow_active>
</defaults>
</action>
<!-- Change privileged settings like e.g.: Lua script code -->
<action id="org.eruption.manage">
<description>Manage the Eruption daemon</description>
<message>Authentication is required to manage the Eruption daemon</message>
<defaults>
<allow_any>auth_admin_keep</allow_any>
<allow_inactive>auth_admin_keep</allow_inactive>
<allow_active>auth_admin_keep</allow_active>
</defaults>
</action>I will have to think about this some more...
cheesits456
SHU-red
I absolutely love this driver, it works amazingly well and opens up so many opportunities for doing cool stuff with the keyboard - you've done some amazing work :)
A suggestion I have is that the
eruptionctl switch profilecommand should also look for profiles stored in a directory such as~/.config/eruption/profiles, and theactive_scriptsarray should also look for scripts stored in~/.config/eruption/scripts. That'll allow each user to make their own configs and stuff unique to that individual user, and it won't require root privileges to modify