search

erusev / parsedown

Better Markdown Parser in PHP
https://parsedown.org
MIT License
14.77k stars 1.12k forks source link

Update .travis.yml #741

Closed GrahamCampbell closed 4 years ago

GrahamCampbell commented 4 years ago

Ping.

GrahamCampbell commented 4 years ago

Ping.

erusev commented 4 years ago

Sorry for taking me so long to respond. Could you please explain the change? Thanks!

GrahamCampbell commented 4 years ago

It adds PHP 7.4 to the test suite, and pins the dists to the highest available for each PHP version, so next time Travis changes the default dist, stuff won't break again.

erusev commented 4 years ago

Sounds good. Is setting dists a common practice? Are there disadvantages? Thanks!

GrahamCampbell commented 4 years ago

Yes, it's pretty common. Only advantages. You were setting the dist in the old config too, but that didn't didn't give you PHP 7.4. The only difference is now I am setting it for each version separately.

erusev commented 4 years ago

Great! Thanks!