erusev / parsedown

Better Markdown Parser in PHP
https://parsedown.org
MIT License
14.76k stars 1.12k forks source link

Add class method visibility to currently implicit methods #770

Open Ayesh opened 4 years ago

Ayesh commented 4 years ago

There are few methods in the Parsedown class that do not explicitly declare visibility. Protected methods are declared as such, but I would like to propose that we mark all implicit public methods as public.

It's considered a good practice, and PSR-2 and 12 both recommend to declare visibility modifiers too.