search

ervin90 / airhead-research

Automatically exported from code.google.com/p/airhead-research
0 stars 0 forks source link

DependencyVector updates #72

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Purpose of code changes on this branch:

1. Notable bug fixes to DependencyPath expansion and filtering

2. Support for combing Noun Phrase nodes into a single node

3. New Acceptor classes that actually work with the data sets we have

4. Change to the Acceptor interface to improve filtering performance

When reviewing my code changes, please focus on:

1. Clear comments for the dependency path noun phrase merging

2. The layout for the new Acceptor classes and their utility classes.  The 
different tag sets could be handled by some centralized location.  
(DependencyExtractorManager ?)  I'm against trying to have the acceptors 
generate their patterns on the fly depending on which tag set is being used 
(which sounds too hair-raising), but I'm all for any proposals to make the 
classes a bit more structured.

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by David.Ju...@gmail.com on 13 Oct 2010 at 5:44

GoogleCodeExporter commented 8 years ago 
Closing the earlier, superseded code review.

Original comment by David.Ju...@gmail.com on 22 Oct 2010 at 1:28