search

erwanp / pytexit

Convert a Python expression to a LaTeX formula
https://pytexit.readthedocs.io/
Other
114 stars 31 forks source link

Linting : black, isort, pre-commit #20

Closed erwanp closed 2 years ago

erwanp commented 3 years ago

Standardize development tools. Run:

and associated Lint tests

manelbdcosta commented 3 years ago

Hey @erwanp! Do you mind if I take this issue? If not, could you clarify at what stage you would prefer to have black and isort be ran? Travis or pre-commit hook?

Thanks!

erwanp commented 3 years ago

Hello @manelbdcosta, please take it !

In another (larger) project RADIS, we have a linting stage set-up directly on Travis-CI right after the main tests. I was envisioning something similar. If you have a better idea go for it !

manelbdcosta commented 3 years ago

@erwanp sounds good! Will start working on it then 😃 . Could you assign it to me please?

Thanks!

manelbdcosta commented 3 years ago

Opened an issue to try and figure out an issue I'm having with isort on python2.7 (working for all other python version, branch)

erwanp commented 3 years ago

Nice @manelbdcosta it seems it's time to stop support of Python 2. Just remove it from the tested versions. If pytexit keeps working on it perfect, else it's OK at this point.

erwanp commented 2 years ago

Closed by #27