Closed maillardj closed 3 years ago
Merging #15 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #15 +/- ##
=======================================
Coverage 23.93% 23.93%
=======================================
Files 19 19
Lines 1780 1780
=======================================
Hits 426 426
Misses 1354 1354
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 55f7e19...55f7e19. Read the comment docs.
Hello ! 2 small Git problems happened :
in your second-to-last commit you removed lines from the test files, but they are still in Git history. So the repository size will not change.
you Merged (= pull changes and create merge commit) instead of Rebasing (pull changes without creating a new commit), so now your own pull request includes changes from other people (see the list of commits above).
It will be quite hard to clean the history. What I suggest instead :
save your changed and new files locally
clone again, or reset to the latest version (04e4ffe)
paste your changed and new files
commit them in one or two commits (one for the changes, one for the tests?)
open a new PR
Fixed in #16