search

erwanp / qtplaskin

A graphical tool to explore ZdPlaskin Results
GNU Lesser General Public License v3.0
7 stars 5 forks source link

Fix: set_xlim for reactWidget #3

Closed githeap closed 5 years ago

githeap commented 5 years ago

Looks like a typo while doing copy-paste.

Try to import data from directory (Ctrl+I) > switch to Reactions tab > plot reaction rate > plot another reaction rate Exception window pop-ups with message:

An unhandled exception was raised: Traceback (most recent call last): File "qtplaskin/main.py", line 532, in update_react_graph self.condWidget.axes[0].set_xlim(former_xrange) IndexError: list index out of range

As I can understand it we try to set xlim for condition graph, but we don't have any yet. Unfortunately, I don't know how to write tests for PyQt, so I can't provide a proper testcase.

erwanp commented 5 years ago

I'm not worried about not having tests there, it does not impact the physics. Merging. Thank you for the contribution!