search

erwanvivien / fast_qr

Ultra fast QRCode generation
https://fast-qr.com/
MIT License
197 stars 29 forks source link

After upgrading to 0.8.3, I get index out of bounds: the len is 0 but the index is 0 #19

Closed svenstaro closed 1 year ago

svenstaro commented 1 year ago

In my project miniserve, I get errors from inside fast_qr since upgrading to 0.8.3: https://github.com/svenstaro/miniserve/actions/runs/4175872918/jobs/7231388083

I believe this is a bug recently introduced in fast_qr itself.

erwanvivien commented 1 year ago

I've looked into it, it is indeed an unfortunate bug from my part... I would have caught it if I had run the examples (CI or local 🥲)

@AntoniosBarotsis Thanks for the PR, however it does not fix the issue :/ I will fix it in 20-30 min

svenstaro commented 1 year ago

Thanks for fixing this. Could you cut a release with this?

erwanvivien commented 1 year ago

@svenstaro Sorry I had gone eating :) The release is now live https://crates.io/crates/fast_qr

Edit: as expected it's 0.8.4

erwanvivien commented 1 year ago

Thanks for your report, I have now automated those checks and it should not go live again