Closed AntoniosBarotsis closed 1 year ago
It is fine not to commit the pkg, I do that when upgrading version usually.
I will look at that, since it really helps reducing the size of the wasm package, thanks for the hindsight
There's also lol_alloc
but the author mentioned how it's not really tested in production.
I think we'll just go with no alloc, thus using dlmalloc-rs
. Thanks Antonios
After trying, it "only" adds 2kB to the gzip archive, while it matters, it's better than leaking memory
Hey @erwanvivien, can we get this patch published on crates.io? I've a project that uses fast_qr in Wasm, and GitHub's security bot keeps giving me grief :upside_down_face:.
Dang, super sorry, I really thought I had done it. Will do right now
@maciejhirsz Update to 8.5 :) Again, sorry for the delay
wee_alloc
is no longer maintained and has a few critical open issues (memory leaks), see here.This reverts back to the recommended
dlmalloc-rs
.I ran the
wasm-pack.sh
file and everything seems fine but I have not tested this from JS directly. A few other PRs seem to just remove the extrawee_alloc
stuff with no other change so this should be fine. I have also not committed any of the changes that happen to thepkg/*
files when I runwasm-pack.sh
, should I do that?