search

erwanvivien / fast_qr

Ultra fast QRCode generation
https://fast-qr.com/
MIT License
197 stars 29 forks source link

implement error trait for QRCodeError struct #28

Closed akhildevelops closed 1 year ago

akhildevelops commented 1 year ago

It would be nice if std::error::Error is implemented for QRCodeError struct. It will be easy for error handling.

erwanvivien commented 1 year ago

Sure, will do :)

erwanvivien commented 1 year ago

@akhildevelops Please tell me if this satifies your needs. https://github.com/erwanvivien/fast_qr/pull/29

akhildevelops commented 1 year ago

Cool @erwanvivien , This is fine but why are you only targeting for non wasm targets.

erwanvivien commented 1 year ago

I had not tested, and thought it would increase the Wasm package, but it did not, I updated the PR and will merge it