search

erwanvivien / fast_qr

Ultra fast QRCode generation
https://fast-qr.com/
MIT License
197 stars 29 forks source link

wasm-bindgen feature #37

Closed astrale-sharp closed 1 year ago

astrale-sharp commented 1 year ago

For use via wasmi, wasm-bindgen is a problem, would you consider putting it behind a feature? If it's straightforward I could probably even find time to create a PR if you're interested, I have a temporary fix in my fork here

astrale-sharp commented 1 year ago

really nice project btw :3

erwanvivien commented 1 year ago

Hey 👋 Could you explain more about why wasm-bindgen is a problem, I'm not aware of the issue!

astrale-sharp commented 1 year ago

https://github.com/rustwasm/wasm-bindgen/issues/3421

In my limited understanding, wasm-bindgen is made for the web, as such it requires webassembly functions available only through the browser.

But the work here https://github.com/EpicEricEE/typst-plugins is made to bundle fast_qr as a plugin for typst, hence we don't have browser capabilities.

erwanvivien commented 1 year ago

Alright then 👍

Do you want to PR the branch in EpicEricEE?

astrale-sharp commented 1 year ago

Apparently they're on it so absolutly, i guess !