search

erwijet / tigerwatch

An easy way for RIT students to track and monitor their Dining Dollars
https://tigerwatch.app
8 stars 2 forks source link

navbar: fix padding on bottom bar #104

Closed Mstrodl closed 2 years ago

netlify[bot] commented 2 years ago

Deploy Preview for distracted-pare-04fe9c ready!

Name Link
Latest commit edb24afb9f23acaf846a896ac8c5436a42f7c434
Latest deploy log https://app.netlify.com/sites/distracted-pare-04fe9c/deploys/626ed16f759c0a000942315a
Deploy Preview https://deploy-preview-104--distracted-pare-04fe9c.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

erwijet commented 2 years ago

Looks good, but since the navbar snaps to the top while loading, it may need to be hidden when isLoading is true. TigerwatchNavBar may need to be moved to be a direct child of the ReactRouter like TigerwatchAppBar since App.tsx owns that state. Honestly though, TigerwatchAppBar and TigerwatchNavBar should have been rendered at the same depth anyway from the start lol.