erwincoumans / tiny-differentiable-simulator

Tiny Differentiable Simulator is a header-only C++ and CUDA physics library for reinforcement learning and robotics with zero dependencies.
Apache License 2.0
1.2k stars 129 forks source link

WIP: fix rotated inertia #102

Closed eric-heiden closed 3 years ago

eric-heiden commented 3 years ago

This PR fixes a bug when applying a rotation to inertia matrices defined in the URDF file. WIP on correcting the floating-base case for the ant leg.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

eric-heiden commented 3 years ago

@googlebot I signed it!

erwincoumans commented 3 years ago

Thanks a lot Eric. It looks like the new tests don't pass in CI?

eric-heiden commented 3 years ago

I forgot to commit my changes to test_rbdl so that a random base transform is only set for the tests of floating-base and not fixed-base systems.

erwincoumans commented 3 years ago

Thanks for the contribution, LGTM.