erwindon / SaltGUI

A web interface for managing SaltStack based infrastructure.
MIT License
520 stars 43 forks source link

output of 'pillar.items' is incorrect #645

Open erwindon opened 2 hours ago

erwindon commented 2 hours ago

Describe the bug When command 'pillar.items' is used from commandbox, the output is organized by the key-names instead of the minion-names.

To Reproduce Steps to reproduce the behaviour:

  1. Click on '>_'
  2. Enter "*"
  3. Enter "pillar.items"
  4. Click "Run command"
  5. See error

Expected behaviour Output is organized by minion.

Additional context This bug is present since b7bd41a70b8888adc96c4e825d3b9d22553a8f3a and that was June 2018

erwindon commented 2 hours ago

analysis: that commit added recognition of documentation-output. output of pillars.items is recognized as documentation and showed as such since then.

erwindon commented 2 hours ago

root cause: insufficient validation all output that consists of a dict with just string values are assumed to be documentation output.

erwindon commented 1 hour ago

solution: