search

erwinhenraat / PythonExamples

Repository with simple Python examples usable with our achievement system.
1 stars 0 forks source link

DRY don't repeat yourself #1

Closed erwinhenraat closed 1 year ago

erwinhenraat commented 3 years ago

In callme.py

def callMe(name, number): print("&: Hello?") time.sleep(1) print("&: Who's there?") time.sleep(1) print("#: It's me "+ name) time.sleep(1) print("&:Hi "+ name+ " i'm sorry i'm busy right now can i call you back?") time.sleep(1) print("#: sure thing.") time.sleep(1) print("&: What's your number?") time.sleep(1) print("#it's "+number) time.sleep(1) print("&: Got it! call you later, Bye!") time.sleep(1) print("#: Bye!") time.sleep(1) print("click...")

callMe(sys.argv[1], sys.argv[2])

Dit kan veel compacter en minder herhalend zodat de code beter herbruikbaar wordt:

def callMe(name, number, text, waitTime): print(text) time.sleep(waitTime)

callMe("erwin", "0633706470", "&: Hello?" , 1)

SilvanDomino commented 3 years ago

Je kan ook de opmaak van de code netter maken.

erwinhenraat commented 3 years ago

Ja ik snap het maar er is nu geen tijd om dit te fixen het is ook niet superbelangrijk

erwinhenraat commented 3 years ago

Ik begrijp het probleem niet helemaal. Zou je nog meer uitleg willen geven

SilvanDomino commented 3 years ago 
def callMe(name, number, text, waitTime):
  print(text)
  time.sleep(waitTime)
erwinhenraat commented 3 years ago

`def callMe(name, number): print("&: Hello?") time.sleep(1) print("&: Who's there?") time.sleep(1) print("#: It's me "+ name) time.sleep(1) print("&:Hi "+ name+ " i'm sorry i'm busy right now can i call you back?") time.sleep(1) print("#: sure thing.") time.sleep(1) print("&: What's your number?") time.sleep(1) print("#it's "+number) time.sleep(1) print("&: Got it! call you later, Bye!") time.sleep(1) print("#: Bye!") time.sleep(1) print("click...")

callMe(sys.argv[1], sys.argv[2])`

erwinhenraat commented 3 years ago 

print("&: Hello?")
time.sleep(1)
print("&: Who's there?")
time.sleep(1)
print("#: It's me "+ name)
time.sleep(1)
print("&:Hi "+ name+ " i'm sorry i'm busy right now can i call you back?")
time.sleep(1)
print("#: sure thing.")
time.sleep(1)
print("&: What's your number?")
time.sleep(1)
print("#it's "+number)
time.sleep(1)
print("&: Got it! call you later, Bye!")
time.sleep(1)
print("#: Bye!")
time.sleep(1)
print("click...")

callMe(sys.argv[1], sys.argv[2])