nus-pe-bot
commented
3 years ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Lacking input validation for list
Issue description
Since only alphanumeric chars are allowed for GAME_ID, I should not expect other characters to be a valid search character, since it will never match anything.
Steps to reproduce the issue
- List with
game --list --What's the expected result?
- Error message restricting dashes in a search keyword.
What's the actual result?
- No error is given and no game matches
Additional details
- Reason for severity: Having validations can improve the user experience.
[original: nus-cs2103-AY2122S1/pe-interim#1852] [original labels: severity.Low type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Rationale
- This is intended by design, as there is no reason to limit the keyword, as mentioned, it will not match anything, and the expected result will just be empty. eg. This behavior also happens for many other products and is not a bug - such as the module website:
- The user has no reason/purpose to filter weird characters that do not even exist in the game id or the friend id. If they do, they should expect to see nothing, as they have no friend id or game ids with these weird characters.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [x] I disagree
Reason for disagreement: I don't see it is a duplicate with another issue. This involves two different features. The one I'm highlighting has to do with friend --get FRIEND_ID which is not related to game --list --.
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: I think this is a valid bug that needs to address.
From the above screenshot we can identify that the NAME and FRIEND_ID is limited to 20 characters. However, the get feature is allowing the user to search more than 20 characters. And with the screenshot that I submit earlier, the input should have limit to 20 characters
:question: Issue type
Team chose [type.FeatureFlaw]
Originally [type.DocumentationBug]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
:question: Issue severity
Team chose [severity.Low]
Originally [severity.VeryLow]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
As the FRIEND_ID was limited to 20 characters,
UG reference:
I was able to enter a search key that is more than 20 characters.
Steps to reproduce: enter friend --list Draco239123i213912i3921392132132193219321932913129393219312993219321932193129 (that is more than 20 characters)