search

erwinqxy / pe

0 stars 0 forks source link

Incorrect time format / domain #13

Open erwinqxy opened 3 years ago

erwinqxy commented 3 years ago

Screenshot 2021-11-12 at 5.32.45 PM.png

User guide indicates that the START_hour or END_hour is an integer between 0 and 24 inclusive, however, I don't think 24 is a valid hour.

Screenshot 2021-11-12 at 5.33.28 PM.png

nus-pe-bot commented 3 years ago

Team's Response

Rationale

24 refers to the 24th hour from the start of the day. There are 24 hours in a day, and limiting END_HOUR to 23 would mean the user is only able to set the time from 0000 to 2300, completely omitting the 24th hour of the day (from 11 pm to midnight). Hence our team decided to allow input from 0 to 24.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I believe 2400 is the same as 0000. As such, 2400 shouldn't even be allowed in the first place.

For example if I were to book an hour slot, I will book 2300 - 0000. Here is a counterexample, if I were to accept your team's rationale, so how do u interpret 2400 - 0000?

For more info: Screenshot 2021-11-17 at 1.12.30 AM.png