erwinqxy / pe

0 stars 0 forks source link

Able to override booking if there is already a booking and dashboard for booking not updated when a new command is entered #14

Open erwinqxy opened 3 years ago

erwinqxy commented 3 years ago

Booking was made even though a previous booking was already made.

Steps to reproduce: (for example) friend --schedule Draco -p 15 24 2 -f 1 friend --schedule Draco -p 18 22 2 -f 1 friend --schedule Draco -p 19 20 2 -f 1

Even though I changed the timing, the schedule timetable reflects the old one Screenshot 2021-11-12 at 5.37.25 PM.png

friend --get Draco

nus-pe-bot commented 3 years ago

Team's Response

Rationale

In the example above, the friend Draco was already free from 1500 - 2400 on Tuesday (day 2) in the first command. Hence when setting the schedule from 1800 - 2200 and 1900 - 2000 on Tuesday as free, the schedule does not update as both 1800 - 2200 and 1900 - 2000 are encompassed in 1500 - 2400. Marking the user as free when the user is already free should not cause any change and hence this is the expected functionality of the command.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Essentially what I am trying to highlight is that the timing on the dashboard does not update to the latest free timing.

For example first instance 1500-2400 then 1800-2200 then 1900-2000

and the schedule did not update according to the user's new free timing, and probably is not overriding the old instance of free.