search

es-shims / es5-shim

ECMAScript 5 compatibility shims for legacy (and modern) JavaScript engines
MIT License
7.12k stars 895 forks source link

Rounding errors with toExponential in Edge 15/16 #453

Closed redchair123 closed 3 years ago

redchair123 commented 6 years ago

See https://github.com/Microsoft/ChakraCore/issues/3929 and https://github.com/Microsoft/ChakraCore/issues/4421 . Reproducible example:

(-6.9e-11).toExponential(4);

Pretty much every other JS engine, even IE8+, give the expected "-6.9000e-11" but Edge 15/16 give "-6.8000e-11"

ping @ljharb

obastemur commented 6 years ago

The issue was fixed on ChakraCore release1.8. The same fix should apply to upcoming Edge release.

ljharb commented 6 years ago

@obastemur do you know which edge version ended up fixing it?

obastemur commented 6 years ago

@ljharb Edge17 should be fine. (just tested and it works)

SheetJSDev commented 6 years ago

FYI this is still a failure in Edge17 revision 17.17134 (the version used in sauce labs)