search

es-tooling / ecosystem-cleanup

A place to keep track of ongoing efforts to clean up the JS ecosystem
405 stars 2 forks source link

migrate stripe to use URLSearchParams #3

Open 43081j opened 10 months ago

43081j commented 10 months ago

The stripe node package can be found here: https://github.com/stripe/stripe-node

it supports node >12 which should mean we can safely move to using URLSearchParams instead of the qs package.

We should contribute upstream for this one.

Note that stripe uses nested query string parameters (i.e. they have keys like foo[bar][baz]=123). So we should probably use fast-querystring or nested-querystring

talentlessguy commented 5 months ago

Seems like the PR is already here: https://github.com/stripe/stripe-node/pull/2116