Open 43081j opened 10 months ago
The URL
change has been opened in twilio/twilio-node#998 FYI
The change to URLSearchParams
will need an equivalent nested query stringifier which uses URLSearchParams
under the hood I think. So may be that it should continue using qs
for now.
edit:
we should be able to move them to fast-querystring
or nested-querystring
merged on twilio's end ❤️
we still need to move off qs
at some point
the twilio node package can be found here: https://github.com/twilio/twilio-node
it depends on both of the following:
qs
(replace with nativeURLSearchParams
)url-parse
(replace with nativeURL
)twilio defines an engine constraint of
>=14
, so we should be fine moving to these built-ins.we should contribute upstream for this.
Note that twilio uses nested query string params (e.g.
foo[bar]=123
). So it may make more sense to look for a modern alternative which usesURLSearchParams
rather than removing a dependency.