es-tooling / ecosystem-cleanup

A place to keep track of ongoing efforts to clean up the JS ecosystem
405 stars 2 forks source link

migrate auth0 to URLSearchParams #5

Open 43081j opened 10 months ago

43081j commented 10 months ago

the auth0 library here: https://github.com/auth0/auth0.js

could likely migrate to using URLSearchParams instead of the qs package.

they do not specify a node constraint so we should note to the maintainers in any contribution we do that it will introduce a minimum node version (iirc >=10).

if they need nesting support (foo[bar]=baz), we should use fast-querystring or nested-querystring

max-arias commented 5 months ago

Their usage:

qs.stringify

43081j commented 5 months ago

note we now have picoquery available too: https://github.com/43081j/picoquery

so we could use this with the custom delimiter. however, it doesn't have an equivalent to encode: false since URL params are meant to be encoded (so it is by design that such an option doesn't exist).

may be possible it isn't needed though