search

es-tooling / ecosystem-cleanup

A place to keep track of ongoing efforts to clean up the JS ecosystem
393 stars 2 forks source link

Replace uri-js #60

Open valadaptive opened 4 months ago

valadaptive commented 4 months ago

uri-js is supposed to use the punycode package, but it accidentally imports the Node builtin instead, which now prints an annoying deprecation warning in everyone's console.

This is reported upstream as https://github.com/garycourt/uri-js/pull/95, but the original maintainer appears to have gone AWOL. Replacing uri-js in downstream repositories would solve this annoying issue.

I believe that the built-in JS URL global supports most, if not all, use cases, but I'm not sure if any projects rely on any subtle semantics or how the WHATWG URL standard differs exactly from RFC 3986.

valadaptive commented 4 months ago

ajv replaced it with https://github.com/fastify/fast-uri

AbhiPrasad commented 4 months ago

ajv update: https://github.com/ajv-validator/ajv/pull/2460

AbhiPrasad commented 4 months ago

https://github.com/andreinwald/uri-js-replace is another replacement

AbhiPrasad commented 4 months ago

PR'd here: https://github.com/es-tooling/module-replacements/pull/70

43081j commented 4 months ago

reopening since we can still use this to track replacing it in upstream repos :+1: