search

es-tooling / ecosystem-cleanup

A place to keep track of ongoing efforts to clean up the JS ecosystem
377 stars 2 forks source link

Replace `ora` in electron/rebuild #73

Open 43081j opened 2 months ago

43081j commented 2 months ago

We can replace ora with a lighter alternative (see #71 )

Current npmgraph: https://npmgraph.js.org/?q=@electron/rebuild

We can also replace chalk (in a separate PR if needed), with picocolors.

Usage of ora: https://github.com/electron/rebuild/blob/f5872bb88e8cf9299d7f22e6f6d9d71ff089f76c/src/cli.ts#L103

Namchee commented 2 months ago

Tracked in https://github.com/electron/rebuild/pull/1148

Namchee commented 2 months ago

Seems like it got declined.

43081j commented 2 months ago

We can revisit it at a later time. Many large projects use picocolors, so it may be that a standalone pr is more likely one day