search

es-tooling / ecosystem-cleanup

A place to keep track of ongoing efforts to clean up the JS ecosystem
393 stars 2 forks source link

Replace ReadableStream in pino and pino-pretty #80

Closed benmccann closed 1 week ago

benmccann commented 3 months ago

Can probably use a pass through stream instead

43081j commented 3 months ago

looks like in pino-pretty, readable-stream and pump are used to make a transform stream:

https://github.com/pinojs/pino-pretty/blob/fc408ee1b4cc81f62adb361eeada32b09810414f/index.js#L146-L153

maybe you could just use a Transform stream? like new Transform({transform: someFn})

benmccann commented 1 week ago

I've sent a PR for this