search

es-tooling / ecosystem-cleanup

A place to keep track of ongoing efforts to clean up the JS ecosystem
384 stars 2 forks source link

Migrate semantic-release/github to tinyglobby #98

Open benmccann opened 2 months ago

benmccann commented 2 months ago

https://github.com/semantic-release/github/blob/990bd7335df10153c9b87bf2be57db602b08def0/package.json#L33

ziebam commented 2 months ago

Depends on https://github.com/thecodrr/fdir/issues/106, otherwise migrated locally.

image

43081j commented 2 months ago

Are we sure we should add such a feature to fdir?

I feel like it should be one or the other (with or without a slash) and leave it up to the consumer to add or remove

Meanwhile, we could strip the end slash ourselves and still get this over the line right?

SuperchupuDev commented 1 month ago

@ziebam i'm not sure if that is a blocker to the migration, we should probably ask the semantic-release maintainers to see if trailing slashes in results would break users or not

ziebam commented 1 month ago

I've opened a PR: https://github.com/semantic-release/github/pull/938. I manually map the results to match the previous behavior, but I noted in a comment that I'm open to updating the test instead in case the trailing slash isn't breaking.

GuskiS commented 1 month ago

Can aggregate-error also be removed since engine.node states node20 is needed and aggregate-error mentions that node15 has it already builtin?

EDIT: Link to semantic-release repo.

mcmxcdev commented 1 month ago

Can aggregate-error also be removed since engine.node states node20 is needed and aggregate-error mentions that node15 has it already builtin?

Opened a PR for it in https://github.com/es-tooling/ecosystem-cleanup/issues/98#issuecomment-2395217908