search

es-tooling / eslint-plugin-depend

An ESLint plugin for suggesting optimisations in choice of dependency, native equivalents, etc.
MIT License
336 stars 4 forks source link

Fix broken link #10

Closed karlhorky closed 5 months ago

karlhorky commented 5 months ago

The URLs generated by getDocsURL() are currently 404ing

I found another repo that may have the details

karlhorky commented 5 months ago

Oh but this is the same one that is used below for getReplacementsDocUrl(), so I guess my suggestion here is incorrect

43081j commented 5 months ago

good catch!

it should be the url to the rule's docs:

https://github.com/es-tooling/eslint-plugin-depend/blob/main/docs/rules/${name}.md
karlhorky commented 5 months ago

@43081j thanks! Updated.

43081j commented 5 months ago

one minor fix needed in rule-meta_test.ts it seems, just updating the assertion to match

will get a new version published once you can update that 👍

43081j commented 5 months ago

sorted it for you while i was in there already 👍

thanks a lot for fixing it 🙏

karlhorky commented 5 months ago

@43081j ah sorry didn't see the CI failure, thanks for reviewing, fixing and merging!