search

es-tooling / module-replacements-codemods

MIT License
188 stars 26 forks source link

fix: import name reliance across various codemods #64

Closed MeLlamoPablo closed 3 months ago

MeLlamoPablo commented 3 months ago

This PR fixes reliance on hardcoded import names across various codemods. Developers may choose to import packages with non-standard names like var banana = require("array-includes"); in which our codemod would break the code by removing the import without replacing the usages.

This PR also updates tests to ensure the "non-standard import name" case is tested. I figured I'd update the existing tests in-place, since adding new cases feels like too much overhead/boilerplate but I'm happy to make the change if you'd rather have them as separate cases.

thepassle commented 3 months ago

This is great man, I had this on my list, thanks for the PR!