search

es-tooling / module-replacements-codemods

MIT License
188 stars 26 forks source link

Fix progress indicator of `npm run which` #84

Closed filipre closed 3 months ago

filipre commented 3 months ago

I noticed the percentage is a bit off. The which script only lists native and micro-util replacements but there are preferred replacements in the package as well which counted towards the progress. What should the percentage represent? This PR uses native and micro-util replacements only.

thepassle commented 3 months ago

Hehe yeah I noticed this too the other day. We also have some codemods that are not micro-utils or native/polyfills, so the numbers are skewed a bit. I think its fine to native and micro-util 👍 We can probably get rid of the script pretty soon too, since we've already implemented the bulk of them