search

es128 / progeny

:baby: Recursively finds dependencies of style and template source files
MIT License
29 stars 15 forks source link

Convert the whole package to vanilla JS #21

Closed diagramatics closed 7 years ago

diagramatics commented 8 years ago

As requested, I had spare time to attempt converting this to vanilla JS. The amount of one-liner .map(), .filter() and .reduce() calls are quite a lot so I was tempted to add Babel and ES6 in as well, but I haven't.

Converted both plugin and test suite. Let me know if you have any concerns.

es128 commented 8 years ago

Thanks! I agree this would be helped by modern syntax features (and it's why coffeescript was well-suited as well), but it seems to still look ok. I still think it's worth the tradeoff to maintain the code like this rather than bring in a heavy build step. Yes, I had that with coffeescript before, but nowadays I'm more inclined to simplify the project structure than trade one for another. But if you have more free time to spare, I'd be willing to evaluate a separate PR for moving in that direction.

Will take a closer look a bit later when I have more time to focus on it before I go ahead and merge.

Is there anything else on your own wishlist that you think should be addressed here before we go ahead and call it 1.0?

diagramatics commented 8 years ago

I guess I'd like to get a coverage tracker in place and get the tests to 100% first so we can be confident about the refactoring itself.

Babel is a nicety to have and plus because we're not using an unofficial standard like Coffeescript it makes a good transition to drop it in the future once we stop supporting Node <4. That's my two cents at least.