search

es128 / progeny

:baby: Recursively finds dependencies of style and template source files
MIT License
29 stars 15 forks source link

add preserveMagic option #23

Closed shvaikalesh closed 8 years ago

shvaikalesh commented 8 years ago
  1. code style fixes & strict mode in tests
  2. defaults by extension are now applied correclty
  3. adds preserveMagic and tests
es128 commented 8 years ago
  1. This is a big patch. Wish you would have tackled each of those 3 items in separate PRs
  2. Can you please describe the use case? I find preserveMagic to be a very confusing name for this, but I'm not sure yet what to suggest as an alternative. I suspect knowing more about how it's intended to be used will help.
  3. What happens when this intersects with potentialDeps: false?
  4. Please include readme documentation about the new option.
paulmillr commented 8 years ago

Looks good.

@es128 this tackles the long-standing issue when import * in stylus (etc) did not import newly created stylus partial files.