search

es128 / progeny

:baby: Recursively finds dependencies of style and template source files
MIT License
29 stars 15 forks source link

add slm #31

Closed denar90 closed 7 years ago

sormy commented 7 years ago

Nice PR. Update README.md with note about new functionality, please.

denar90 commented 7 years ago

@sormy sorry forgot about readme. Is it enough? Do you wanna me to add some example, e.g. like jade ?

es128 commented 7 years ago

Don't need all these redundant tests, they're not accomplishing anything as far as exercising progeny's internals.

What we don't have now and could use for all the built-in extension settings, including a .slm version, is fixtures and tests that check different scenarios that are format-specific.

If you feel like setting up the structure for that here with .slm as the first example that would be great, but I'd also accept the PR without it if you just remove all the test copies you made.

denar90 commented 7 years ago

@es128 thanks, I've removed copy-pasted tests. You can merge it if it's ok.