esa / CCSDS_MO_APIS

Holds the generated Java APIs for the CCSDS MO services
Other
2 stars 6 forks source link

Fix string based structures #18

Closed yannickl96 closed 5 years ago

yannickl96 commented 5 years ago

As a solution for https://github.com/esa/CCSDS_MO_APIS/issues/17 I suggest the following fixes. They just initialize the underlying values with empty strings to make the code more robust. Another possibility would be to forbid empty or null constructors.

SamCooper commented 5 years ago

Its fine with me, but just be careful about differing coding styles (curly brackets on different/same line) as it starts to make things look untidy.

dmarszk commented 5 years ago

Aligned coding style more in-line with the existing files.