search

esa / CCSDS_MO_TRANS

REPOSITORY ARCHIVED - for the latest version please go to https://github.com/esa/mo-services-java
Other
3 stars 7 forks source link

Exception rethrown upwards #27

Closed CesarCoelho closed 7 years ago

CesarCoelho commented 7 years ago

Fixes this issue: https://github.com/esa/CCSDS_MO_TRANS/issues/12

gbonnefille commented 7 years ago

Why not rethrowing the exception in the getElementCount?

I suspect there will be a lot of impact, but it seems better to inform the caller that the information was not computed. With such a change, the caller will continue its processing and probably fail later due to missing elements. Such situation can complexify the investigation on error, even if the logbook contains the relevant error.

SamCooper commented 7 years ago

Because that would mean changing the MAL Java API which is a little more involved.

But you could add a RID on the MAL Java to that effect

CesarCoelho commented 7 years ago

Done