esa / LADDS

Large-scale Deterministic Debris Simulation - Codebase for the ARIADNA Study between TU Munich and ESA's Advanced Concepts Team.
GNU General Public License v3.0
5 stars 3 forks source link

Smarter domain decomposition #144

Closed gomezzz closed 2 years ago

gomezzz commented 2 years ago

Description

TODO:

Related Pull Requests

Resolved Issues

How Has This Been Tested?

gomezzz commented 2 years ago

@FG-TUM any suggestions for what tests we should add for this?

FG-TUM commented 2 years ago

@FG-TUM any suggestions for what tests we should add for this?

Add a few MPI tests. Make sure

FYI: The MPI tests are always executed with 8 ranks.

gomezzz commented 2 years ago

@FG-TUM any suggestions for what tests we should add for this?

Add a few MPI tests. Make sure

* [x]  the partitioning works (do we catch the case if there are more ranks than particles? Do we care? 😁 ),

* [x]  the migration works

* [ ]  collisions during migration are caught.

FYI: The MPI tests are always executed with 8 ranks.

Added most tests. Collisions not atm as that is pretty complex actually (basically need to run a whole iteration) and we still have to fix #145. I'd suggest to do it there so we can wrap this one up first. Also, because this check also should be done for regularGrid, I reckon?

FG-TUM commented 2 years ago

Also, because this check also should be done for regularGrid, I reckon?

Yes this should be done independently of the underlying decomposition.

I'd suggest to do it there so we can wrap this one up first

Ok