esa / NIDN

Neural Inverse Design of Nanostructures
GNU General Public License v3.0
38 stars 6 forks source link

Test for FDTD baseline failing #98

Closed gomezzz closed 2 years ago

gomezzz commented 2 years ago

Issue

Problem Description

test_deviation_from_original_fdtd in fdtd_test.py currently fails for me with a fairly large error. Maybe some fdtd setting changed?

assert tensor(0.340131309937) < 5e-06

However the notebook comparing the two works fine for me. So either the baseline is broken or some parameter is wrong?

Expected Behavior

Smaller errors

What Needs to be Done

Double check if it fails on other machines as well. If so, check parameters / baseline

How Can It Be Tested or Reproduced

run pytest