esa / asn1scc

ASN1SCC: An open source ASN.1 compiler for embedded systems
https://www.thanassis.space/asn1.html
Other
272 stars 58 forks source link

Outdated docker hub image #271

Closed swthorn closed 1 year ago

swthorn commented 1 year ago

image

It doesn't look like the docker hub image has been updated since #221 was closed. Can it be automatically pushed after each commit?

Thanks!

usr3-1415 commented 1 year ago

I've created a GitHub Action with two jobs to automatically build and push the Docker image after each commit. The build job is triggered automatically after a commit, but only in the master branch. The push image job is triggered manually via GitHub's Action page. However, the push image job requires the secrets.DOCKERHUB_USERNAME and secrets.DOCKERHUB_PASSWORD secrets to be set. Unfortunately, I am not the owner of this repository and cannot set these secrets myself.

@maxime-esa, would it be possible for you to set these variables so that the GitHub Action can push the Docker image to Docker Hub? Thank you!

maxime-esa commented 1 year ago

@usr3-1415 No, I am also not the owner. @ttsiodras ?

ttsiodras commented 1 year ago

Since I left the Agency more than a year ago, I think the best course of action is to transfer ownership to you @maxime-esa , no? You'll have to update the links in the TASTE repos yourself, of course.

Shall I?

maxime-esa commented 1 year ago

Sure please do @ttsiodras Thanks!

ttsiodras commented 1 year ago

@maxime-esa "maxime-esa/asn1scc already exists" - I guess you have a fork you need to remove first.

maxime-esa commented 1 year ago

@ttsiodras I have deleted the fork I had

ttsiodras commented 1 year ago

@maxime-esa ...and I have initiated the transfer. Check your email, Github must have sent you a confirmation - you need to accept the transfer for it to go through.

End of an era... what we started with George back in 2008, is now officially in your hands :-)

maxime-esa commented 1 year ago

Thanks... Done!

Back to the original problem now... @usr3-1415 I found the area where I can create "secrets" in the Github repo. So I can indeed create secrets.DOCKERHUB_USERNAME and secrets.DOCKERHUB_PASSWORD. Can you let me know (privately) what values I should use?

maxime-esa commented 1 year ago

As stated in #280 we won't maintain the docker container as there are pre-built releases that work out of the box.