search

esa / dSGP4

dSGP4: differentiable SGP4. Supports differentiability, ML integration & embarassingly parallel computations
https://esa.github.io/dSGP4/
GNU General Public License v3.0
25 stars 8 forks source link

Unused variable - method - not sure if this was on purpose #8

Closed grantcurell closed 3 weeks ago

grantcurell commented 6 months ago

Function initl takes as arguments:

def initl(
       xke, j2,
       ecco,   epoch,  inclo,   no,
       method,
       opsmode,
       ):

method is passed in sgp4init.py

However, method is never used in the code. It is set statically here

It's not clear if this is deliberate or not or a holdover from debugging where it was fixed.

Sceki commented 6 months ago

Thank you for raising this! I will fix this together with a few other cleanup in a coming soon PR :)

Sceki commented 3 weeks ago

done in #16 , thanks again