search

esa / dSGP4

dSGP4: differentiable SGP4. Supports differentiability, ML integration & embarassingly parallel computations
https://esa.github.io/dSGP4/
GNU General Public License v3.0
25 stars 8 forks source link

Batched mode propagation for satellites with _isimp flag activated #9

Closed Rex2000viola closed 5 months ago

Rex2000viola commented 6 months ago

I modified the pipeline in order to propagate both satellites with _isimp flag activated and not.

Sceki commented 6 months ago

Hi @Rex2000viola , thanks for the PR :)

Can you please add tests to make sure that the behavior is as intended. You can add them here: https://github.com/esa/dSGP4/blob/master/tests/test_batched_sgp4.py, by adding for instance: def test_isimp_batched(self): .... where you make sure that the behavior of isimp in batch mode is the same as the one without batch mode --> e.g. propagating the TLEs at a few random future times and making sure the outputs correspond.

For that you might need a few TLEs that have the isimp flag active (you can add them to the end of file) similarly to this

Rex2000viola commented 6 months ago

Hello @Sceki , as requested, I have inserted the test file using 4 TLEs, two with the flag active and two without. Additionally, I have updated the corrected sgp4_batched file. I apologize for the delay.

Sceki commented 5 months ago

@Rex2000viola I think it's almost ready to merge :) We just miss:

Once these two are pushed I can go ahead and merge

Rex2000viola commented 5 months ago

@Sceki I apologize for the wait. I hope it is okay now.

Sceki commented 5 months ago

@Rex2000viola Looks like it's good to go!

Thanks a lot for the contribution, I will merge it! And good luck with your thesis :)