search

esa / pagmo2

A C++ platform to perform parallel computations of optimisation tasks (global and local) via the asynchronous generalized island model.
https://esa.github.io/pagmo2/
GNU General Public License v3.0
823 stars 161 forks source link

Bug in the NSPSO test case #427

Closed bluescarni closed 4 years ago

bluescarni commented 4 years ago

Here:

https://github.com/esa/pagmo2/blob/master/tests/nspso.cpp#L173

std::all_of() is invoked, but its result is not checked by a BOOST_CHECK() statement. If one adds the BOOST_CHECK(), then the test fails.

@darioizzo would you mind taking a look?

bluescarni commented 4 years ago

Pinging @Sceki as well.

darioizzo commented 4 years ago

I think that test was, in @Sceki mind, supposed to test that NSPSO would work on integer problems. But I do not think that NSPSO is, infact its marked as M-U. So I would say the test is to be removed altogether.

bluescarni commented 4 years ago

Ok, I ditched the test in #426.

Sceki commented 4 years ago

I think that test was, in @Sceki mind, supposed to test that NSPSO would work on integer problems. But I do not think that NSPSO is, infact its marked as M-U. So I would say the test is to be removed altogether.

Indeed.. sorry about that!