esa / pagmo2

A C++ platform to perform parallel computations of optimisation tasks (global and local) via the asynchronous generalized island model.
https://esa.github.io/pagmo2/
GNU General Public License v3.0
808 stars 160 forks source link

Set C++ standard so that it propagates to users #458

Closed Bidski closed 3 years ago

Bidski commented 3 years ago

See #456

Setting the C++ standard in this way causes it to show up in pagmo_export.cmake as an INTERFACE_COMPILE_FEATURE which, in turn, will instruct anyone linking against the pagmo cmake target to compile using the C++17 standard (at minimum). See cmake docs

bluescarni commented 3 years ago

@Bidski that's great, thanks a lot for digging this out.

Could I ask you to make the following further additions to the PR:

If you don't have time/bandwidth for this, I'll do this myself, just let me know.

Bidski commented 3 years ago

@bluescarni I have applied the changes you requested

bluescarni commented 3 years ago

@Bidski great, thanks a lot! I'll merge as soon as the CI runs.