WORHP plugin for pagmo

[darioizzo]

The WORHP NLP solver is wrapped as a pagmo plugin

[bluescarni]

I am a bit concerned by the legal status of those headers that seem to be copy pasted from WOHRP. Do we have permission to distribute those? Under which license? We should at least try to clarify this with the WOHRP developers and add a note somewhere.

[darioizzo]

I have asked via mail to the WORHP authors if its ok to have their headers 'as are' in our github.

BTW, they change the headers at each release (also minor) so we now are using 12.1, but we have no guarantee that the next build will be compatible YAY!

[bluescarni]

Is there a way to get the version number of WORHP via a function available in the DLL? That way you could at least detect the version of the DLL at the beginning and error out in case there's a version mismatch... Perhaps something you could suggest the WORHP devs.

[darioizzo]

@bluescarni There is a way. The point is that if the modification between versions is small as they claim (they say they only add param and do not change the prototypes) different library version should also work. So we have 2 options

1) Force our users to use 1.12.1 (risking that worhp will eventually not make the download available anymore) 2) Document that 1.12.1 is what we developed around, but also that newer versions could work if the API has not changed (and older versions). Maybe print a warning on screen if there is a version mismatch.

Whats your pick?

[codecov-io]

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@675ec55). Click here to learn what that means. The diff coverage is 95.41%.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   96.67%           
=========================================
  Files             ?        4           
  Lines             ?      872           
  Branches          ?        0           
=========================================
  Hits              ?      843           
  Misses            ?       29           
  Partials          ?        0

Impacted Files	Coverage Δ
tests/worhp.cpp	100% <100%> (ø)
tests/snopt7.cpp	100% <100%> (ø)
include/pagmo_plugins_nonfree/snopt7.hpp	98.35% <100%> (ø)
include/pagmo_plugins_nonfree/worhp.hpp	93.88% <93.88%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 675ec55...b80f10e. Read the comment docs.