search

esa / pygmo2

A Python platform to perform parallel computations of optimisation tasks (global and local) via the asynchronous generalized island model.
https://esa.github.io/pygmo2/
Mozilla Public License 2.0
422 stars 57 forks source link

Feature/partlyfixed #87

Closed mlooz closed 2 years ago

mlooz commented 2 years ago

A draft for a meta problem that allows to set some arguments to fixed values and thus reduce the dimension of the search space. Still in progress, not marked as such to trigger the CI

bluescarni commented 2 years ago

@mlooz thanks for the PR, I think this is a great addition.

I was wondering what you think about a simplification in the constructor API. Instead of writing, e.g.,

fixed_arguments=[1], fixed_flags=[True, False, False]

would it be feasible to have something like

fixed_arguments=[1, None, None]

instead?

I have a few more minor stylistic points when you think this is ready, but I think it is already looking good.

mlooz commented 2 years ago

Good point, @bluescarni ! I switched to the simpler format, I was already using it in some scripts.

Thanks for the feedback, what stylistic points do you have in mind?

mlooz commented 2 years ago

The only failing test now is the doctest, which fails because https://projects.coin-or.org/ is unresponsive. I suggest replacing it with https://coin-or.github.io/Ipopt/

bluescarni commented 2 years ago

@mlooz I have left a couple of comments in the review.

mlooz commented 2 years ago

@bluescarni Thanks, I addressed the comments