Adding linter tests to continuous integration in Pykep

esa / pykep

PyKEP is a scientific library providing basic tools for research in interplanetary trajectory design.

http://esa.github.io/pykep/

GNU General Public License v3.0

334 stars 96 forks source link

Adding linter tests to continuous integration in Pykep #137

Closed pabloem closed 3 years ago

pabloem commented 3 years ago

Issue #134 would be caught by a linter. It may be a good idea to implement lint checks for pykep. What do you think @darioizzo ?

This PR adds an extra build type which runs lint checks (and currently fails). A healthy lint check could keep those failures out.

This PR is a work in progress for now.

darioizzo commented 3 years ago

Thanks for this PR, I think its a great addition to have a linting build ... hopefully you will manage to have it green 👍

pabloem commented 3 years ago

sure, I can make it green, and then mark it ready to review.

pabloem commented 3 years ago

@darioizzo this is ready for review.

As you see, I worked with @albertoibm on this change. The commit messages are self-descriptive. Let us know if this can be merged.

A reasonable question to ask is whether we need a new workflow for lint, or if we should just run lint on every python-3x test

pabloem commented 3 years ago

hi @darioizzo - did you have a chance to take a look? Most changes should be full-positives. Only special questions I expect are related to installing dependencies.

darioizzo commented 3 years ago

Had a look its fine as is. I am merging this for the upcoming release.

I saw the dependencies added to PyPi, sure they provide a better pykep experience.

Thanks for the PR!!! Keep 'em coming :)